On 12/1/16 9:32 PM, Peter Eisentraut wrote:
> I think it would be better to get rid of objargs and have objname be a
> general Node that can contain more specific node types so that there is
> some amount of type tracking. FuncWithArgs would be one such type,
> Typename would be another, Value would be used for simple strings, and
> we could create some other ones, or stick with lcons for some simple
> cases. But then we don't have to make stuff into one-item lists to just
> to satisfy the currently required List.
>
> That's the general idea. But that's a rather big change that I would
> rather break down into smaller pieces.
People wanted to the whole thing at once, so here it is.
Patches 0001 and 0002 are some prep work. Patch 0003 is the main patch
that removes the objargs fields and changes the objname to a generic
Node*. 0004 is an API simplification that could be committed together
with 0003 but I kept it separate for easier review. 0005 accomplishes
the DROP FUNCTION changes. 0006 is some other cleanup that fell out of
this.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers