Re: [COMMITTERS] pgsql: Allow to_timestamp(float8) to convert float infinity to timestam - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Allow to_timestamp(float8) to convert float infinity to timestam
Date
Msg-id 4445.1459300416@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Allow to_timestamp(float8) to convert float infinity to timestam  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [COMMITTERS] pgsql: Allow to_timestamp(float8) to convert float infinity to timestam
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> On Wed, Mar 30, 2016 at 6:09 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Allow to_timestamp(float8) to convert float infinity to timestamp infinity.

> Some of the tests introduced are making MSVC unhappy, because they
> depend on the three-digit behavior that Windows is using, leading to
> those failures:

Ah, I was wondering about that.  The patch as-submitted used "%lf" which
seemed even less likely to be portable, but evidently %g isn't that much
better.

> If the those tests are kept, an alternate output file is necessary (I
> can send a patch if needed, I see the failure locally as well).

I'm inclined to just drop the out-of-range test cases.  They're not that
useful IMO, and alternate expected-files are a real PITA for maintenance.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [BUGS] Re: BUG #13854: SSPI authentication failure: wrong realm name used
Next
From: Michael Paquier
Date:
Subject: Re: [COMMITTERS] pgsql: Allow to_timestamp(float8) to convert float infinity to timestam