Re: pgbench - allow backslash-continuations in custom scripts - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgbench - allow backslash-continuations in custom scripts
Date
Msg-id 44368.1434739913@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgbench - allow backslash-continuations in custom scripts  (Josh Berkus <josh@agliodbs.com>)
List pgsql-hackers
Josh Berkus <josh@agliodbs.com> writes:
> On 05/14/2015 12:10 PM, Fabien COELHO wrote:
>> Add backslash continuations to pgbench custom scripts.

> I don't personally agree.  I believe that it it worth breaking backwards
> compatibility to support line breaks in pgbench statements, and that if
> we're not going to do that, supporting \ continuations is of little value.

I tend to agree on that bottom line; having this be inconsistent with psql
does not seem like a win.

> I'm not clear on why we'd need a full SQL lexer.

So you don't get fooled by semicolons embedded in string literals or
comments.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: pretty bad n_distinct estimate, causing HashAgg OOM on TPC-H
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_regress not waiting for postmaster to stop