Re: [HACKERS] pg_freespacemap question - Mailing list pgsql-patches

From Mark Kirkwood
Subject Re: [HACKERS] pg_freespacemap question
Date
Msg-id 441DEA4D.9000804@paradise.net.nz
Whole thread Raw
In response to Re: [HACKERS] pg_freespacemap question  (Mark Kirkwood <markir@paradise.net.nz>)
Responses Re: [HACKERS] pg_freespacemap question
List pgsql-patches
Mark Kirkwood wrote:
> Tom Lane wrote:
>
>>
>> I do notice a rather serious shortcoming of pg_freespacemap in its
>> current incarnation, which is that it *only* shows you the per-page free
>> space data, and not any of the information that would let you determine
>> what the FSM is doing to filter the raw data.  The per-relation
>> avgRequest and lastPageCount fields would be interesting for instance.
>> Perhaps there should be a second view with one row per relation to
>> carry the appropriate data.
>>
>
> Ok - I did wonder about 2 views, but was unsure if the per-relation
> stuff was interesting. Given that it looks like it is interesting, I'll
> see about getting a second view going.
>

This patch implements the second view for FSM relations. I have renamed
the functions and views to be:

pg_freespacemap_relations
pg_freespacemap_pages

This patch depends on the previous one (which was called simply
'pg_freespacemap.patch').

Cheers

Mark

Attachment

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: Bonjour registration on Intel Macs is broken
Next
From: Mark Kirkwood
Date:
Subject: Pg_buffercache tidy