Re: Patch to remove/report orphaned files - Mailing list pgsql-patches

From Tom Lane
Subject Re: Patch to remove/report orphaned files
Date
Msg-id 4405.990769076@sss.pgh.pa.us
Whole thread Raw
In response to Patch to remove/report orphaned files  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Patch to remove/report orphaned files  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> This patch removes old sort files on postmaster startup, and reports
> orphaned database directory files during database vacuum.

I like the first part, but not the second.  To name just one problem,
it will go berserk after OID wraparound.  The "minimum startup OID"
approach would be ugly even if it weren't fundamentally broken.
That O(N^2) search will get a tad tedious with a lot of tables, too.

I really don't think we have a problem that needs fixing in this area;
surely not a problem bad enough to justify a band-aid as ugly as this.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Patch to remove/report orphaned files
Next
From: Bruce Momjian
Date:
Subject: Re: Patch to remove/report orphaned files