Re: Using XLogFileNameP in critical section - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Using XLogFileNameP in critical section
Date
Msg-id 440.1575387196@sss.pgh.pa.us
Whole thread Raw
In response to Re: Using XLogFileNameP in critical section  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Using XLogFileNameP in critical section  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I'm not sure that the internationalization stuff in issue_xlog_fsync is
> correct.  I think the _() should be gettext_noop(), or alternatively the
> errmsg() should be errmsg_internal(); otherwise the translation is
> invoked twice.  (I didn't verify this.)

Also, buildfarm member drongo is not happy:

postgres.def : error LNK2001: unresolved external symbol XLogFileNameP
[C:\prog\bf\root\HEAD\pgsql.build\postgres.vcxproj]
Release/postgres/postgres.lib : fatal error LNK1120: 1 unresolved externals
[C:\prog\bf\root\HEAD\pgsql.build\postgres.vcxproj]

I'm guessing you missed a reference someplace.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: log bind parameter values on error
Next
From: Fabien COELHO
Date:
Subject: Re: pgbench -i progress output on terminal