Re: pgsql: Index: src/pl/plpython/plpython.c - Mailing list pgsql-committers

From Neil Conway
Subject Re: pgsql: Index: src/pl/plpython/plpython.c
Date
Msg-id 43B45B2F.50202@samurai.com
Whole thread Raw
In response to pgsql: Index: src/pl/plpython/plpython.c  (neilc@postgresql.org (Neil Conway))
List pgsql-committers
Neil Conway wrote:
> Log Message:
> -----------
> Index: src/pl/plpython/plpython.c
> ===================================================================
[...]

*sigh*

Sorry for fat-fingering that: "cvs ci -F ~/the.patch" rather than "cvs
ci -F ~/commit_msg"

The commit message should have been:

In PLy_spi_execute_plan(), PL/Python invokes the type input function
for a Postgres datatype.  The type input function might raise an
exception via elog, which will cause a Python reference leak (the
reference count a temporary Python object will not be decremented).
Therefore, enclose the call to the input function in a PG_TRY()
block and decrement the refcount on the object using PG_CATCH().

-Neil


pgsql-committers by date:

Previous
From: neilc@postgresql.org (Neil Conway)
Date:
Subject: pgsql: Index: src/pl/plpython/plpython.c
Next
From: Andrew Dunstan
Date:
Subject: committers email / archive problems