Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
Date
Msg-id 4379FDA3-9446-4E2C-9C15-32EFE8D4F31B@yandex-team.ru
Whole thread Raw
In response to Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)  (Melanie Plageman <melanieplageman@gmail.com>)
Responses Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
List pgsql-hackers

> On 6 Jan 2026, at 00:24, Melanie Plageman <melanieplageman@gmail.com> wrote:
>
> <v32-0014-Pass-down-information-on-table-modification-to-s.patch>

I've tried to take an attempt to review some patches of this patchset. It's huge and mostly polished.

In a step "Pass down information on table modification to scan node" you pass SO_HINT_REL_READ_ONLY flag in IndexNext()
andBitmapTableScanSetup(), but not in IndexNextWithReorder() and IndexOnlyNext(). Is there a reason why index scans
withordering cannot use on-access VM setting? 

Also, comment about visibilitymap_set() says "Callers that log VM changes separately should use visibilitymap_set()" as
ifvisibilitymap_set() is some other function. 


Best regards, Andrey Borodin.


pgsql-hackers by date:

Previous
From: Nitin Motiani
Date:
Subject: Re: Proposal: Support Logical replication of large objects
Next
From: Japin Li
Date:
Subject: Remove deprecated role membership options from psql help for CREATE USER/GROUP