Re: latest commit breaks tsearch2 - Mailing list pgsql-committers

From Teodor Sigaev
Subject Re: latest commit breaks tsearch2
Date
Msg-id 43786210.8030908@sigaev.ru
Whole thread Raw
In response to latest commit breaks tsearch2  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: latest commit breaks tsearch2  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
> query_gist.c: In function `sizebitvec':
> query_gist.c:203: warning: control reaches end of non-void function
Fixed

>
> Looking at the code, gcc is right to complain --- if this is working for
> you it's only accidental.

It works because index tree was correct but was very far from optimal.


>  I don't much care for the hard-wired
> assumption about the size of TPQTGist either ...

typedef uint64 TPQTGist;

What is your doubt? You suggest to use  sizeof(TPQTGist)*BIT_PER_BYTE?


--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

pgsql-committers by date:

Previous
From: teodor@svr1.postgresql.org (Teodor Sigaev)
Date:
Subject: pgsql: fix returning value
Next
From: Tom Lane
Date:
Subject: Re: latest commit breaks tsearch2