Request a Demo
Home   >   mailing lists

ereport bug - Mailing list pgsql-hackers

From Dmitry Voronin
Subject ereport bug
Date
Msg-id 43691421062049@web19g.yandex.ru
Whole thread
Responses Re: ereport bug
Re: ereport bug
List pgsql-hackers
Tree view
Hello, postgresmen!
 
I found incorrect execution of ereport() macro.
If we pass into ereport() function 2 or more arguments, the macro errcontext does not correct execute. So, ereport() call stack is:
 
errstart
errcontext_msg
set_errcontext_domain
errmsg
errfinish
pg_unreachable
 
This bug causes that error messages (for example, in PL/TCL) are not localized.

Solutions:
- Wrap all errcontext() macro in brackets, that is errcontext("error message %s", "end message") -> (errcontext("error message %s", "end message"))
- Rewrite this macro
- ???
 
I am attaching to this letter a test case that shows the behavior errcontext() macro and the way to fix it.

I am using postgresql 9.4 and test it on gcc 4.7 and gcc 4.8.1.

-- Best regards, Dmitry Voronin

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Async execution of postgres_fdw.
Next
From: Dean Rasheed
Date:
Subject: Re: INSERT ... ON CONFLICT UPDATE and RLS