Re: patch for pg_autovacuum 8.0.x prevent segv for dropped - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: patch for pg_autovacuum 8.0.x prevent segv for dropped
Date
Msg-id 4357C6EC.6020000@dunslane.net
Whole thread Raw
In response to Re: patch for pg_autovacuum 8.0.x prevent segv for dropped tables  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches

Tom Lane wrote:

>daveg <daveg@sonic.net> writes:
>
>
>>Below is a patch for this that should apply against any 8.0.x. The change
>>verifies that the catalog query returned some rows before accessing the row
>>data.
>>
>>
>
>Surely this is completely broken?  AFAICT you are testing the result
>from a VACUUM or ANALYZE command, which is not going to return any
>tuples.
>
>

I guess he should change

    if (PQntuples(res))

to

    if (|PQresultStatus|(res) == PGRES_COMMAND_OK)

?

cheers

andrew



pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: patch for pg_autovacuum 8.0.x prevent segv for dropped tables
Next
From: Chris Browne
Date:
Subject: AIX FAQ update for 5.3 socket address size issue