Re: patch for pg_autovacuum 8.0.x prevent segv for dropped - Mailing list pgsql-patches

From Matthew T. O'Connor
Subject Re: patch for pg_autovacuum 8.0.x prevent segv for dropped
Date
Msg-id 4357C4D0.40105@zeut.net
Whole thread Raw
In response to Re: patch for pg_autovacuum 8.0.x prevent segv for dropped tables  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: patch for pg_autovacuum 8.0.x prevent segv for dropped tables  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> daveg <daveg@sonic.net> writes:
>
>> Below is a patch for this that should apply against any 8.0.x. The change
>> verifies that the catalog query returned some rows before accessing the row
>> data.
>>
>
> Surely this is completely broken?  AFAICT you are testing the result
> from a VACUUM or ANALYZE command, which is not going to return any
> tuples.

Upon further inspection, I think you are right.  I would think that
instead of checking the query result with PQntuples, it should probably
be checked with |PQresultStatus.

Matt

|

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: patch for pg_autovacuum 8.0.x prevent segv for dropped tables
Next
From: Tom Lane
Date:
Subject: Re: patch for pg_autovacuum 8.0.x prevent segv for dropped tables