Re: force C locale for temp regression installations - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: force C locale for temp regression installations
Date
Msg-id 430F3F74.2060208@dunslane.net
Whole thread Raw
In response to Re: force C locale for temp regression installations  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: force C locale for temp regression installations  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches

Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>
>
>>The attached tiny patch forces C locale on the temp location built by
>>pg_regress - it fixes recent regression problems observed on Windows.
>>
>>
>
>I don't think this is really a good idea, because it makes it impossible
>to run the tests any other way.
>
>If you're speaking of the current buildfarm results from loris, I'm
>unconvinced that that's a locale problem --- the opr_sanity results
>in particular shouldn't be locale-sensitive.
>
>

(through bleary dilated eyes)

But we aleady do it implicitly for everything but Windows now, with this:

  unset LC_COLLATE LC_CTYPE LC_MONETARY LC_MESSAGES LC_NUMERIC LC_TIME
LC_ALL LANG LANGUAGE

Both Petr and I have seen that with --no-locale set the regression set
gets a clean run. If you want us to dig deeper into those 9 failures,
just tell us what to look for.

cheers

andrew

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: force C locale for temp regression installations
Next
From: Petr Jelinek
Date:
Subject: Re: force C locale for temp regression installations