Re: Lowercase folding - simple patch? - Mailing list pgsql-odbc

Does somebody know, wether the following code is correct:

odbcapi.c:


RETCODE        SQL_API
SQLColumns(HSTMT StatementHandle, ...)
{
...

        if (SC_is_lower_case(stmt, conn)) /* case-insensitive identifier */
            ifallupper = FALSE;

In above there is one hidden problem:
SC_is_lower_case() is implemented as follows:

statement.h:#define     SC_is_lower_case(a, b) (a->options.metadata_id,
b->connInfo.lower_case_identifier)


GCC compiler complaints (-Wall enabled) about the definition:

odbcapi.c:140: warning: left-hand operand of comma expression has no effect

So this means, that a->options.metadata_id is not used at all. Maybe the
comma
should be replaced with && or || ?


Marko Ristola