Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c) - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c)
Date
Msg-id 42CD72BE-2B13-43C3-989D-C1E3D987C842@yesql.se
Whole thread Raw
In response to Fix a possible socket leak at Windows (src/backend/port/win32/socket.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c)
List pgsql-hackers
> On 13 Jan 2024, at 22:38, Ranier Vilela <ranier.vf@gmail.com> wrote:

> In the pgwin32_socket function (src/backend/port/win32/socket.c), there is a possible socket leak if the socket
cannotbe made non-blocking. 

I don't know Windows well enough to comment on the implications of not calling
closesocket here, but it definitely seems like a prudent thing to do
backpatched down to 12. Unless objections I'll do that.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: "Li, Yong"
Date:
Subject: Re: archive modules loose ends
Next
From: Alena Rybakina
Date:
Subject: Re: POC: GROUP BY optimization