Re: patch: garbage error strings in libpq - Mailing list pgsql-patches

From Neil Conway
Subject Re: patch: garbage error strings in libpq
Date
Msg-id 42CBE5ED.4050207@samurai.com
Whole thread Raw
In response to Re: patch: garbage error strings in libpq  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: patch: garbage error strings in libpq  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: patch: garbage error strings in libpq  (jtv@xs4all.nl)
List pgsql-patches
Tom Lane wrote:
> I think this is all irrelevant language-lawyering; jtv spotted the true
> problem which is that we do not protect errno during the *first* call of
> libpq_gettext.

I think you're missing the point. Obviously the current code is wrong,
the debate is over the best way to fix it. Jeroen's interpretation of
the spec suggests that merely having libpq_gettext() preserve errno is
not sufficient. I'm not convinced this his interpretation is correct,
but it is a question worth resolving.

-Neil

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: patch: garbage error strings in libpq
Next
From: Tom Lane
Date:
Subject: Re: patch: garbage error strings in libpq