Re: Problem with dblink regression test - Mailing list pgsql-hackers

From Joe Conway
Subject Re: Problem with dblink regression test
Date
Msg-id 42B8DFB8.6080002@joeconway.com
Whole thread Raw
In response to Re: Problem with dblink regression test  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Problem with dblink regression test
List pgsql-hackers
Tom Lane wrote:
> "Jim C. Nasby" <decibel@decibel.org> writes:
> 
>>It appears that the dblink regression test defaults to port 5432. I've
>>been trying to get platypus to compile clean on HEAD and 8_0 and it's
>>been failing on dblink.
> 
> 
> There are several buildfarm machines failing like this.  I think a
> possible solution is for the postmaster to do putenv("PGPORT=nnn")
> so that libpq instances running in postmaster children will default
> to the local installation's actual port rather than some compiled-in
> default port.
> 
> This is certainly not without its downsides, but if you are running
> a postmaster at a nondefault port then I think you ought to be aware
> that leaving dblink to choose a default port is a fragile idea.
> 
> Thoughts?

(Sorry for the slow response, I'm away from home again, this time in 
South Korea)

I think most people would expect that if they don't specify a port, they 
would be talking to the same postmaster that they are running under on 
whatever port it is using, not some compiled in default. So your 
proposal makes perfect sense to me. Then the dblink regression test 
would not specify a port at all, correct?

Joe


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_terminate_backend idea
Next
From: "Andrew Dunstan"
Date:
Subject: Re: pl/pgsql: END verbosity