Re: bugfix - contrib/pgbench - Mailing list pgsql-patches

From Neil Conway
Subject Re: bugfix - contrib/pgbench
Date
Msg-id 42916C31.6010505@samurai.com
Whole thread Raw
In response to bugfix - contrib/pgbench  (ITAGAKI Takahiro <itagaki.takahiro@lab.ntt.co.jp>)
Responses Re: bugfix - contrib/pgbench
List pgsql-patches
ITAGAKI Takahiro wrote:
> --- 622,628 ----
>       for (i = 0; i < (sizeof(DDLAFTERs) / sizeof(char *)); i++)
>       {
>           res = PQexec(con, DDLAFTERs[i]);
> !         if (strncmp(DDLAFTERs[i], "drop", 4) && PQresultStatus(res) != PGRES_COMMAND_OK)
>           {
>               fprintf(stderr, "%s", PQerrorMessage(con));
>               exit(1);

None of the DDL in DDLAFTERs begins with "drop", so ISTM the right fix
is to just remove the strncmp().

-Neil

pgsql-patches by date:

Previous
From: Nigel Kukard
Date:
Subject: unsubscribe
Next
From: ITAGAKI Takahiro
Date:
Subject: Re: bugfix - contrib/pgbench