Re: Windows: openssl & gssapi dislike each other - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Windows: openssl & gssapi dislike each other
Date
Msg-id 425201.1717885284@sss.pgh.pa.us
Whole thread Raw
In response to Re: Windows: openssl & gssapi dislike each other  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Windows: openssl & gssapi dislike each other
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2024-06-08 Sa 06:22, Imran Zaheer wrote:
>> Now this can either be solved by just just undefine the macro defined
>> by wincrypt.h as done here [3]
>> Or we should rearrange our headers. Openssl header should be at the
>> bottom (after the gssapi includes).

> Let's be consistent and use the #undef from [3].

+1.  Depending on header order is not great, especially when you have
to make it depend on an order that is directly contradictory to
project conventions [0].

            regards, tom lane

[0] https://wiki.postgresql.org/wiki/Committing_checklist#Policies



pgsql-hackers by date:

Previous
From: Aaron Altman
Date:
Subject: Re: Fix grammar oddities in comments
Next
From: "David E. Wheeler"
Date:
Subject: Shouldn't jsonpath .string() Unwrap?