Re: contrib/pg_buffercache

From: Andrew Dunstan
Subject: Re: contrib/pg_buffercache
Date: ,
Msg-id: 42385D6C.9050806@dunslane.net
(view: Whole thread, Raw)
In response to: Re: contrib/pg_buffercache  (Mark Kirkwood)
Responses: Re: contrib/pg_buffercache  (Mark Kirkwood)
List: pgsql-hackers

Tree view

contrib/pg_buffercache  ("Andrew Dunstan", )
 Re: contrib/pg_buffercache  (Mark Kirkwood, )
 Re: contrib/pg_buffercache  (Mark Kirkwood, )
  Re: contrib/pg_buffercache  (Andrew Dunstan, )
   Re: contrib/pg_buffercache  (Mark Kirkwood, )
    Re: contrib/pg_buffercache  (Andrew Dunstan, )
     Re: contrib/pg_buffercache  (Mark Kirkwood, )
 Transitive Closure and 'pg_inherits'  (Ioannis Theoharis, )
  Re: Transitive Closure and 'pg_inherits'  (Tom Lane, )
 Recursive SQL  (Ioannis Theoharis, )
  Re: Recursive SQL  (Euler Taveira de Oliveira, )

It fixes the build error on Windows - haven't tried because i don't have
time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
defined on Cygwin - see previous almost endless discussions.

cheers

andrew

Mark Kirkwood wrote:

> Andrew Dunstan wrote:
>
>> ... is apparently broken for Windows and Cygwin. See for example
>> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=loris&dt=2005-03-16%2001:55:33
>>
>>
>
> Andrew,
>
> The attached patch seems to sort it for me, can you give it try on
> win32 and cygwin?
>
> cheers
>
> Mark
>
>------------------------------------------------------------------------
>
>--- pg_buffercache_pages.c.orig    Sun Mar 13 04:36:24 2005
>+++ pg_buffercache_pages.c    Wed Mar 16 20:57:52 2005
>@@ -17,6 +17,11 @@
> 
> #define NUM_BUFFERCACHE_PAGES_ELEM    6
> 
>+#ifdef WIN32
>+extern DLLIMPORT BufferDesc        *BufferDescriptors;
>+extern DLLIMPORT volatile uint32    InterruptHoldoffCount;
>+#endif
>+
> 
> /*
>  * Record structure holding the to be exposed cache data.
>  
>
>------------------------------------------------------------------------
>
>
>---------------------------(end of broadcast)---------------------------
>TIP 1: subscribe and unsubscribe commands go to 
>  
>



pgsql-hackers by date:

From: Thomas Hallgren
Date:
Subject: Savepoints and SPI
From: Alvaro Herrera
Date:
Subject: Re: Savepoints and SPI