Re: postgreSQL-8.0.1 configure --enable-thread-safety with - Mailing list pgsql-hackers

From Neil Conway
Subject Re: postgreSQL-8.0.1 configure --enable-thread-safety with
Date
Msg-id 422E926E.1010103@samurai.com
Whole thread Raw
In response to Re: postgreSQL-8.0.1 configure --enable-thread-safety with  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: postgreSQL-8.0.1 configure --enable-thread-safety with
List pgsql-hackers
Bruce Momjian wrote:
> The attached patch should remove the warnings but I am not applying it
> because a non-static/extern global variable should be fine in C code.

What's the harm in applying it? Variables and functions not used outside 
the compilation unit in which they are defined _should_ be marked 
static; it's not required, but I think it's good style.

-Neil


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: two questions related to tablespace in PG8.0.1
Next
From: Vikram Kalsi
Date:
Subject: Re: postgreSQL-8.0.1 configure --enable-thread-safety with icc-8.1 on RHEL-AS3 Itanium-2 gives error