Request a Demo
Home   >   mailing lists

Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Date
Msg-id 4226AED7-E38F-419B-AAED-9BC853FB55DE@yandex-team.ru
Whole thread Raw
In response to Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 

> On 27 Dec 2022, at 04:32, Michael Paquier <michael@paquier.xyz> wrote:
>
> Sure.  Done that too, and applied the change after a last lookup.

Sorry for bumping old thread. I'm toying with enabling wal_consistency_checking here and there.
I've found the way with PG_TEST_EXTRA=wal_consistency_checking, but also I was thinking what if we enable it
everywhere...
Overall it seems difficult to just add PGOPTION="-c wal_consistency_checking=all" on a buildfarm animal.
This happens mostly because frontends cannot connect with unprivileged role with wal_consistency_checking in PGOPTION.

But this particular test of pg_waldump fails due to LSN comparison logic.
The test expects LSN in saved file to be strictly less than LSN in file name.
This is violated when wal_consistency_checking is enabled: LSNs are equal.

Maybe we can relax the test here?

Thanks!


Best regards, Andrey Borodin.
Attachment

pgsql-hackers by date:

Previous
From: "zengman"
Date:
Subject: Re: [[BUG] pg_stat_statements crashes with var and non-var expressions in IN clause
Next
From: Fujii Masao
Date:
Subject: Re: [PATCH] Add sampling statistics to autoanalyze log output