Re: pg_basebackup vs. Windows and tablespaces - Mailing list pgsql-hackers

From Dilip kumar
Subject Re: pg_basebackup vs. Windows and tablespaces
Date
Msg-id 4205E661176A124FAF891E0A6BA91352663515BC@szxeml509-mbs.china.huawei.com
Whole thread
In response to Re: pg_basebackup vs. Windows and tablespaces  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: pg_basebackup vs. Windows and tablespaces
List pgsql-hackers

On 20 August 2014 19:49, Amit Kapila Wrote

 

 

 

> There are some comments I would like to share with you
>
>  
>
> 1.      Rebase the patch to current GIT head.

>Done.

 

>> +                      initStringInfo(&symlinkfbuf);
>>
>>             I think declaration and initialization of symlinkfbuf string can be moved under #ifdef WIN32 compile time macro,
>>
>> for other platform it’s simply allocated and freed which can be avoided.

>Agreed, I have changed the patch as per your suggestion.

  
I have done the testing and behavior is as per expectation,

Do we need to do some document change? I mean is this limitation on windows is mentioned anywhere ?

If no change then i will move the patch to “Ready For Committer”.

 

Thanks & Regards,

Dilip

 

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Support for N synchronous standby servers
Next
From: Craig Ringer
Date:
Subject: Re: Aussie timezone database changes incoming