Re: ReadBuffer() error checking - Mailing list pgsql-patches

From Neil Conway
Subject Re: ReadBuffer() error checking
Date
Msg-id 4196BDA7.8070508@samurai.com
Whole thread Raw
In response to Re: ReadBuffer() error checking  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Agreed.  I get the impression that at one time it was not so, but
> certainly for the last many years there's been no need to test.

Patch applied.

> A related issue in the same general area is that the smgr code is
> currently implemented to elog on error, but its API still reflects
> an assumption that it will return a failure indication.  Changing
> the API is a larger change than I want to see during late beta,
> but it's a cleanup that would be reasonable to undertake during
> a future development cycle, if you're interested.

Sure, I'll take a look at it once we branch for 8.0.

-Neil

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Give the TODO list a little more verbose explanation
Next
From: Neil Conway
Date:
Subject: Re: PITR docs enhancements