Re: psql \! WIN32 cleanup - Mailing list pgsql-patches

From Gaetano Mendola
Subject Re: psql \! WIN32 cleanup
Date
Msg-id 418C92FA.4000908@bigfoot.com
Whole thread Raw
In response to Re: psql \! WIN32 cleanup  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian wrote:
> Tom Lane wrote:
>
>>Bruce Momjian <pgman@candle.pha.pa.us> writes:
>>
>>>The attached applied patch tests for COMSPEC in the right place and
>>>supplies a reasonable shell default on Win32.
>>
>>>+ #define DEFAULT_SHELL "c:/windows/system32/cmd.exe"
>>
>>Is it really a good idea to assume that the Windows installation is on
>>drive C: ?
>>
>>(This is an honest question, not a rhetorical one.  I dunno whether
>>inserting the C: is better than leaving it off.  I can think of cases
>>where either way will break, but I'm unsure what's most likely in
>>practice.)
>
>
> Not sure.  Should we just do "/windows/system32/cmd.exe" and leave off
> the C:?  The previous default was "/bin/sh" and that certainly will not
> work on Win32.

I think another path to try if COMSPEC is not defined is:

%SystemRoot%/system32/cmd.exe



Regards
Gaetano Mendola


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: ON COMMIT and foreign keys
Next
From: "Dave Page"
Date:
Subject: Re: psql \! WIN32 cleanup