Re: [PATCH] SAOP nullability analysis below NOT/BooleanTest - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] SAOP nullability analysis below NOT/BooleanTest
Date
Msg-id 4171084.1785258195@sss.pgh.pa.us
Whole thread
List pgsql-hackers
Ayush Tiwari <ayushtiwari.slg01@gmail.com> writes:
> While looking at the recent work around converting NOT IN sublinks to
> anti-joins, I came across what looks like a possible issue in the
> ScalarArrayOpExpr handling in find_nonnullable_rels() and
> find_nonnullable_vars().

This is an odd one.  Why did I add the falseOK argument to
is_strict_saop and then not use it in all three callers?  Sadly, I don't
recall what I was thinking twenty years ago.  But you're clearly right
that all of them should be accounting for this effect.

I'm inclined to merge this patch with your other SAOP correction,
since they're so closely related.

            regards, tom lane



Attachment

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: add list of major features to the v19 release notes
Next
From: "Matheus Alcantara"
Date:
Subject: Re: hashjoins vs. Bloom filters (yet again)