Re: cast pid_t to int when using *printf - Mailing list pgsql-patches

From Neil Conway
Subject Re: cast pid_t to int when using *printf
Date
Msg-id 416764BF.6080601@samurai.com
Whole thread Raw
In response to Re: cast pid_t to int when using *printf  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: cast pid_t to int when using *printf
List pgsql-patches
Bruce Momjian wrote:
> Tom Lane wrote:
>>Traditionally PIDs fit in 16 bits, let alone 32.  I'd recommend that we
>>standardize on casting pid_t to int for printing purposes;
>
>
> Done.

Uh, what? Your patch removes the casting of pid_t to int -- Tom was
suggesting that we consistently cast pid_t to int. (Also your patch
removes casting from uid_t to int in the case of geteuid() -- why?)

For instance:

http://developer.postgresql.org/cvsweb.cgi/pgsql-server/src/bin/psql/command.c.diff?r1=1.126&r2=1.127

-Neil


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Win32 Version numbering patch
Next
From: Oliver Jowett
Date:
Subject: Re: cast pid_t to int when using *printf