Re: Bug in dlgCast - Mailing list pgadmin-hackers

From Andreas Pflug
Subject Re: Bug in dlgCast
Date
Msg-id 4163B8FA.1080602@pse-consulting.de
Whole thread Raw
In response to Bug in dlgCast  (Alexander Borkowski <alexander.borkowski@abri.une.edu.au>)
Responses Re: Bug in dlgCast  (Alexander Borkowski <alexander.borkowski@abri.une.edu.au>)
List pgadmin-hackers
Alexander Borkowski wrote:
> Dear all,
>
> I just encountered a bug in 1.2.0 Beta 2 (Win XP).
>
> When selecting the source or target type in the "New Cast" dialog, the
> application crashes. What IMHO happens is that the call to
> txtName->SetValue(wxEmptyString) in dlgCast::CheckChange()
> (src/ui/dlgCast.cpp line 121) generates a new wxEVT_COMMAND_TEXT_UPDATED
> event. This event triggers a call to dlgProperty::OnChange() which in
> turn calls the virtual dlgCast::CheckChange() and so on ... until
> pgAdmin crashes.

Your analysis is right. The problem is that txtName is handled in a
generalized way in dlgProperty, which handles user inputs, but in the
case of dlgCast it's a calculated non-editable name.

Fix: renamed to txtCastname.

Thanks for reporting!

Regards,
Andreas

pgadmin-hackers by date:

Previous
From: Alexander Borkowski
Date:
Subject: Bug in dlgCast
Next
From: cvs@cvs.pgadmin.org
Date:
Subject: CVS Commit by andreas: Fix cast property crash [Alexander Borkowski]