Re: -HEAD build failure on OpenBSD 3.6-current/Sparc64 - Mailing list pgsql-hackers

From Stefan Kaltenbrunner
Subject Re: -HEAD build failure on OpenBSD 3.6-current/Sparc64
Date
Msg-id 4162CB7F.5020708@kaltenbrunner.cc
Whole thread Raw
In response to Re: -HEAD build failure on OpenBSD 3.6-current/Sparc64 +patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Stefan Kaltenbrunner <mm-mailinglist@madness.at> writes:
> 
>>Tom Lane wrote:
>>
>>>Why did you remove -DPIC ?
> 
> 
>>uhm partly because I sent the wrong patch and partly because I didn't 
>>understood what that to do anyway(in the !Sparc case). The only place I 
>>can find on my machine where defining PIC seems to have an effect is in 
>>/usr/include/sparc64/asm.h - so I would guess it was a no-op anyway on 
>>Openbsd/!Sparc.
> 
> 
> It may do nothing, but since it was in there and not causing trouble,
> I think it's probably best to leave it.

agreed - leaving it in is definitely a safer approach

> 
> 
>>But my programming skills are somewhat limited so I would definitly need 
>>some guidance on this or I will just sent another patch with adds -DPIC 
>>back for both cases if you want.
> 
> 
> No, I can change it.

thanks


Stefan


pgsql-hackers by date:

Previous
From: Andreas Pflug
Date:
Subject: Re: acl_admin.sql
Next
From: Bruce Momjian
Date:
Subject: Problem with Win32 pg_dump linking and symbols