Re: Busted includes somewhere near worker_internal.h - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Busted includes somewhere near worker_internal.h
Date
Msg-id 4149152.1595098758@sss.pgh.pa.us
Whole thread Raw
In response to Re: Busted includes somewhere near worker_internal.h  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2020-07-17 16:09:14 -0400, Tom Lane wrote:
>> headerscheck and cpluspluscheck are both unhappy about this:
>> ./src/include/replication/worker_internal.h:49:2: error: unknown type name 'slock_t'
>>     slock_t  relmutex;
>>     ^~~~~~~

> I think including spin.h is the right fix, given that it needs to know
> the size of s_lock.

Done that way.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Default setting for enable_hashagg_disk
Next
From: Ranier Vilela
Date:
Subject: Re: CID 1428952 (#1 of 1): Out-of-bounds access (OVERRUN) (src/backend/commands/async.c)