Re: 7.3 failure on platypus - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: 7.3 failure on platypus
Date
Msg-id 4125.24.211.165.134.1134443561.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: 7.3 failure on platypus  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: 7.3 failure on platypus  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane said:
> "Andrew Dunstan" <andrew@dunslane.net> writes:
>> I don't care that much if 7.3 fails to build on fbsd 6. The flipside
>> is that the fix for this particular problem appears to be very simple
>> and very low risk, unless I'm going blind.
>
> Possibly --- if you've gone to the trouble of identifying the relevant
> patch, we might as well apply it.  Send it over.
>

away from my workstation, but it looks to me like the HAVE_STRUCT_SOCKCRED
branch is completely redundant in that function, since the structures in
question are only referred to in a HAVE_CMSGCRED branch.

I think I'd just delete lines 464-470 in
http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-auth.c?annotate=1.71
Jim, can you test that? (I don't have a fbsd box either).

cheers

andrew





pgsql-hackers by date:

Previous
From: Christopher Kings-Lynne
Date:
Subject: Re: Different length lines in COPY CSV
Next
From: "Jim C. Nasby"
Date:
Subject: Re: [GENERAL] missing something obvious about intervals?