Re: pgadmin3 not compliant with gcc-3.4 (?) - Mailing list pgadmin-hackers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andreas Pflug wrote:
| Raphaël Enrici wrote:
|
|> They are both solutions I've seen in other projects where they faced
|> this issue.
|
|
| Both not completely satisfying.

yep.


|>> - deny 3.4 support
|>
|> Impossible for me! Our wxWid does not build with gcc 3.3.x due to a
|> compiler issue fixed in 3.4.x branch. g++ 3.4.x is the only solution I
|> have to get actual pgAdmin III into debian... unless I move back to
|> 2.95 series but IIRC there was problem with it.
|
|
| You can wait for a better spec and gcc 5.6 :-)

Shame on me! I forgot about gcc 5.6 ;)

| Try the new dlgProperty.h.

It works, but I had another error which the patch attached corrects
(based on what you submitted last time):

if g++-3.4 -DHAVE_CONFIG_H -I. -I. -I..
- -DDATA_DIR=\"/usr/share/pgadmin3/\" -Wa
ll -g -I../src/include -I../src/agent/include -I/usr/include/postgresql
- -I./incl
ude -DSSL -I/usr/lib/wx/include/gtk2ud-2.5 -D__WXDEBUG__ -D__WXGTK__
- -D_FILE_OFF
SET_BITS=64 -D_LARGE_FILES -DWX_PRECOMP -DNO_GCC_PRAGMA -I/usr/include
- -DDATA_DI
R=\"/usr/share/pgadmin3/\" -Wall -g -I../src/include
- -I../src/agent/include -g -
O2 -MT frmBackup.o -MD -MP -MF ".deps/frmBackup.Tpo" \
~  -c -o frmBackup.o `test -f 'ui/frmBackup.cpp' || echo
'./'`ui/frmBackup.cpp; \
then mv -f ".deps/frmBackup.Tpo" ".deps/frmBackup.Po"; \
else rm -f ".deps/frmBackup.Tpo"; exit 1; \
fi
../src/include/dlgClasses.h:116: error: `void
ExternProcessDialog::OnClose(wxClo
seEvent&)' is protected
ui/frmBackup.cpp:53: error: within this context
make[3]: *** [frmBackup.o] Error 1
make[3]: Leaving directory
`/BUILD/MY_PGADMIN3/AUTO_PGADMIN/build/debian/pgadmin
3-1.1.0/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/BUILD/MY_PGADMIN3/AUTO_PGADMIN/build/debian/pgadmin
3-1.1.0'
make[1]: *** [all] Error 2
make[1]: Leaving directory
`/BUILD/MY_PGADMIN3/AUTO_PGADMIN/build/debian/pgadmin
3-1.1.0'
make: *** [build-stamp] Error 2


Please recheck the patch, I was not really sure of what should really
become public or not. I saw you made public all the onXX methods in your
last patch although the one really embarassing is the onChange one, so I
tried to copy you ;)

Regards,
Raphaël
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBIMFux3NpDPptARMRAptLAJ9wPCohSdPSObNL6i7A7nMJ/Ru66gCfcPt+
T5p34ai6jBnxOo+biGhly1s=
=g4lq
-----END PGP SIGNATURE-----
*** dlgClasses.h.old    Wed Aug 11 23:20:08 2004
--- dlgClasses.h    Mon Aug 16 16:04:31 2004
***************
*** 111,122 ****
--- 111,132 ----
      int pid;
      bool done, final;

+ #if __GNUC__ >= 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 4)
+     // ANSI spec 11.5 is quite brain dead about pointers of protected members: In order to access
+     // them using the base class name, they can't be protected.
+     //  apparently, only gcc 3.4 knows that; other compilers take protected as protected.
+ public:
+
+ #endif
+
      void OnOK(wxCommandEvent& ev);
      void OnCancel(wxCommandEvent& ev);
      void OnClose(wxCloseEvent& event);
      void OnEndProcess(wxProcessEvent& event);

      void OnPollProcess(wxTimerEvent& event);
+
+ protected:
      void checkStreams();
      void readStream(wxInputStream *input);