Re: pgxs: build infrastructure for extensions v4 - Mailing list pgsql-hackers

From Joe Conway
Subject Re: pgxs: build infrastructure for extensions v4
Date
Msg-id 411124EC.4060604@joeconway.com
Whole thread Raw
In response to Re: pgxs: build infrastructure for extensions v4  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgxs: build infrastructure for extensions v4  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Andrew Dunstan wrote:
> Mark Cave-Ayland wrote:
>> This is because I only get the pgxs directory returned by "pgconfig
>> --pgxs" as opposed to the path to the pgxs.mk file itself - is that the
>> correct thing to do (i.e. the comment is wrong?) or is "pgconfig --pgxs"
>> returning the wrong thing?
>
> needs to be fixed in pg_config.c I think - should be a one-liner.

If the attached looks correct I'll apply it.

Joe
Index: src/bin/pg_config/pg_config.c
===================================================================
RCS file: /cvsroot/pgsql-server/src/bin/pg_config/pg_config.c,v
retrieving revision 1.3
diff -c -r1.3 pg_config.c
*** src/bin/pg_config/pg_config.c    2 Aug 2004 12:34:14 -0000    1.3
--- src/bin/pg_config/pg_config.c    4 Aug 2004 18:00:51 -0000
***************
*** 141,147 ****
          else if (strcmp(argv[i],"--pgxs") == 0)
          {
              get_pkglib_path(mypath,otherpath);
!             strncat(otherpath, "/pgxs", MAXPGPATH-1);
          }

          printf("%s\n",otherpath);
--- 141,147 ----
          else if (strcmp(argv[i],"--pgxs") == 0)
          {
              get_pkglib_path(mypath,otherpath);
!             strncat(otherpath, "/pgxs/src/makefiles/pgxs.mk", MAXPGPATH-1);
          }

          printf("%s\n",otherpath);

pgsql-hackers by date:

Previous
From: "Jim C. Nasby"
Date:
Subject: Re: Anybody have an Oracle PL/SQL reference at hand?
Next
From: Tom Lane
Date:
Subject: Re: PITR - recovery to a particular transaction