Re: pg_ctl patch to integrate apache's rotatelogs - Mailing list pgsql-patches

From Andrew Hammond
Subject Re: pg_ctl patch to integrate apache's rotatelogs
Date
Msg-id 40AA1209.9050801@ca.afilias.info
Whole thread Raw
In response to Re: pg_ctl patch to integrate apache's rotatelogs  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: pg_ctl patch to integrate apache's rotatelogs
List pgsql-patches
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


|>logrotate rotates log files and hups the servers according to a
|>configuration file.  rotatelogs reads the log data on stdin and reopens
|>a new output file once in a while.  The first hunk of your patch was
|>wrong, the rest seemed OK.
|
|
| OK, just to confirm, I backed out the first attached patch, but kept the
| rest, which is my second attached patch.

This looks correct to me.

| I am still confused how these errors remained in the documentation for
| so long.

Probably because non-syslog logging in a production environment is a
very small niche. Which might, unfortunately, be a good argument against
my proposed patch.

Drew
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAqhIGgfzn5SevSpoRAvizAJ0fZRI5o1FuERzUen2ufWwCsz/J2ACghQ7B
agaY+YaC0LIVF/jNCk+QnmA=
=Rsjl
-----END PGP SIGNATURE-----

pgsql-patches by date:

Previous
From: Fabien COELHO
Date:
Subject: add build utilities in default install
Next
From: "Magnus Hagander"
Date:
Subject: Re: Timezone code, one more try