Re: win32 build and test issues - Mailing list pgsql-hackers-win32

From Andrew Dunstan
Subject Re: win32 build and test issues
Date
Msg-id 40953FBC.5040803@dunslane.net
Whole thread Raw
In response to Re: win32 build and test issues  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers-win32
I will post a diff tomorrow. It's the extra blank lines in the
regression output thing that Claudio and others have remarked on. It
happens after every "(nnn rows)" line.

cheers

andrew

Bruce Momjian wrote:

>Andrew, can you illustrate to the group the exact difference in output?
>
>---------------------------------------------------------------------------
>
>Andrew Dunstan wrote:
>
>
>>I have tried  very hard to work out why this patch works for the
>>regression tests in MINGW/MSys, but it doesn't make any sense why this
>>one call should add an extra blank line. Does anyone have any bright
>>ideas? I'm reluctant to say I think we should apply it until the problem
>>is understood and the behaviour explained. But it does appear to work.
>>
>>cheers
>>
>>andrew
>>
>>
>>
>>
>>
>>>>>>Index: print.c
>>>>>>===================================================================
>>>>>>RCS file: /projects/cvsroot/pgsql-server/src/bin/psql/print.c,v
>>>>>>retrieving revision 1.46
>>>>>>diff -c -w -r1.46 print.c
>>>>>>*** print.c     24 Jan 2004 20:43:26 -0000      1.46
>>>>>>--- print.c     30 Apr 2004 16:44:46 -0000
>>>>>>***************
>>>>>>*** 388,394 ****
>>>>>>--- 388,396 ----
>>>>>>               for (ptr = footers; *ptr; ptr++)
>>>>>>                       fprintf(fout, "%s\n", *ptr);
>>>>>>
>>>>>>+ #ifndef WIN32
>>>>>>       fputc('\n', fout);
>>>>>>+ #endif
>>>>>>
>>>>>>       /* clean up */
>>>>>>       free(cell_w);
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>
>>
>>---------------------------(end of broadcast)---------------------------
>>TIP 7: don't forget to increase your free space map settings
>>
>>
>>
>
>
>


pgsql-hackers-win32 by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: win32 build and test issues
Next
From: Claudio Natoli
Date:
Subject: Re: regression failures