Re: win32 build and test issues - Mailing list pgsql-hackers-win32

Magnus Hagander wrote:

>>I'm also thinking of creating a simple commandline interface
>>for pqkill
>>that can be used to make a clean shutdown.
>>
>>
>
>See the win32 status page, there is a link to one already.
>
>//Magnus
>
>
>

I will check it out. Meanwhile, there's promising news. With the patch
below applied to psql, I can run "make check" under MinGW and get all
but 12 tests passing. The remainder appear to be all related to the
timestamp issue, the floating point scientific format issue, and the
join sort order issue, which have been previously noted.

I'm not suggesting applying the patch yet - I'd like to know why the
line end thing cares what platform it is using - presumably regardless
of where it runs it is still using MSVCRT.

cheers

andrew



Index: startup.c
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/bin/psql/startup.c,v
retrieving revision 1.91
diff -c -w -r1.91 startup.c
*** startup.c   22 Apr 2004 14:34:38 -0000      1.91
--- startup.c   30 Apr 2004 16:44:45 -0000
***************
*** 124,129 ****
--- 124,132 ----
                }
        }

+ #ifdef WIN32
+       setvbuf(stderr,NULL,_IONBF,0);
+ #endif
        pset.cur_cmd_source = stdin;
        pset.cur_cmd_interactive = false;
        pset.encoding = PQenv2encoding();
Index: print.c
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/bin/psql/print.c,v
retrieving revision 1.46
diff -c -w -r1.46 print.c
*** print.c     24 Jan 2004 20:43:26 -0000      1.46
--- print.c     30 Apr 2004 16:44:46 -0000
***************
*** 388,394 ****
--- 388,396 ----
                for (ptr = footers; *ptr; ptr++)
                        fprintf(fout, "%s\n", *ptr);

+ #ifndef WIN32
        fputc('\n', fout);
+ #endif

        /* clean up */
        free(cell_w);