Re: Query::targetList and RETURNING - Mailing list pgsql-hackers

From Greg Stark
Subject Re: Query::targetList and RETURNING
Date
Msg-id 407d949e0911100711k76269c9di28ca70def327aa5@mail.gmail.com
Whole thread Raw
In response to Re: Query::targetList and RETURNING  (Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>)
List pgsql-hackers
On Tue, Nov 10, 2009 at 2:56 PM, Marko Tiikkaja
<marko.tiikkaja@cs.helsinki.fi> wrote:
> (Sorry, forgot to CC the list)
>
> Tom Lane wrote:
>>
>> This doesn't really seem like a good idea from here.  You're changing
>> a decision that has something like twenty years' standing in the code,
>> for no real gain.  AFAICS this is just going to move the special cases
>> from point A to point B.
>
> Right, but this way you only have to special-case in grouping_planner(),
> and targetList always means the same thing.

I haven't read through the patch but I can say the existing
arrangement certainly seemed strange to me when I first saw it.

--
greg


pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: Parsing config files in a directory
Next
From: Marko Tiikkaja
Date:
Subject: Re: Query::targetList and RETURNING