Re: [patch] 7.4 initdb - drop trailing slash from $PGDATA - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: [patch] 7.4 initdb - drop trailing slash from $PGDATA
Date
Msg-id 4070.24.211.141.25.1074521385.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: [patch] 7.4 initdb - drop trailing slash from $PGDATA  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane said:
> Peter Eisentraut <peter_e@gmx.net> writes:
>> Jari Aalto wrote:
>>> I made a mistake while running 7.4 under W2k/Cygwin, so perhaps the
>>> patch would give user a little more comfort.
>
>> I don't see how.  Please explain.
>
> CVS-tip initdb seems to be written to suppress any trailing slash in
> the PGDATA path already, so this discussion may be moot.
>

Yes (except that leading slashes are not suppressed). That was deliberate,
for the sake of simplicity and clarity. It has just occurred to me though
that this might have unintended (bad) consequences on Windows if PGDATA is
set to the root of a mapped drive, like "I:/". I will think about that a
little and submit a patch if necessary.

cheers

andrew



pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [patch] 7.4 initdb - drop trailing slash from $PGDATA
Next
From: Reece Hart
Date:
Subject: Re: psql prompts with invisible characters