Request a Demo
Home   >   mailing lists

Re: Mark function arguments of type "Datum *" as "const Datum *" where possible - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Mark function arguments of type "Datum *" as "const Datum *" where possible
Date
Msg-id 4061336.1758898813@sss.pgh.pa.us
Whole thread Raw
In response to Re: Mark function arguments of type "Datum *" as "const Datum *" where possible  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Tree view 
Nathan Bossart <nathandbossart@gmail.com> writes:
> I have mixed feelings about this patch.  I have no concrete objections to
> the technical content, but some questions come to mind.  For example, why
> are we only fixing Datum parameters?

Yeah.  In particular, probably 99% of such Datum arrays also have an
associated array of bool isnull flags.  IMO it makes exactly zero
sense to const-ify the Datums without similar protection for their
isnull flags.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Vladlen Popolitov
Date:
Subject: Re: Avoiding roundoff error in pg_sleep()
Next
From: Álvaro Herrera
Date:
Subject: Re: Remove unused for_all_tables field from AlterPublicationStmt