Re: Re: Reduce amount of WAL generated by CREATE INDEX for gist, ginand sp-gist - Mailing list pgsql-hackers

From David Steele
Subject Re: Re: Reduce amount of WAL generated by CREATE INDEX for gist, ginand sp-gist
Date
Msg-id 4030cc62-c86d-52c6-dc06-087ed0125244@pgmasters.net
Whole thread Raw
In response to Re: Reduce amount of WAL generated by CREATE INDEX for gist, gin andsp-gist  (Andrey Lepikhov <a.lepikhov@postgrespro.ru>)
Responses Re: Reduce amount of WAL generated by CREATE INDEX for gist, gin andsp-gist
List pgsql-hackers
On 2/6/19 2:08 PM, Andrey Lepikhov wrote:
> The patchset had a problem with all-zero pages, has appeared at index
> build stage: the generic_log_relation() routine sends all pages into the
> WAL. So  lsn field at all-zero page was initialized and the
> PageIsVerified() routine detects it as a bad page.
> The solution may be:
> 1. To improve index build algorithms and eliminate the possibility of
> not used pages appearing.
> 2. To mark each page as 'dirty' right after initialization. In this case
> we will got 'empty' page instead of the all-zeroed.
> 3. Do not write into the WAL all-zero pages.
> 
> In the patchset (see attachment) I used approach No.3.
> 
> On 04.02.2019 10:04, Michael Paquier wrote:
>> On Tue, Dec 18, 2018 at 10:41:48AM +0500, Andrey Lepikhov wrote:
>>> Ok. It is used only for demonstration.
>>
>> The latest patch set needs a rebase, so moved to next CF, waiting on
>> author as this got no reviews.

The patch no longer applies so marked Waiting on Author.

Alexander, Heikki, are either of you planning to review the patch in 
this CF?

Regards,
-- 
-David
david@pgmasters.net


pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Re: using index or check in ALTER TABLE SET NOT NULL
Next
From: Peter Eisentraut
Date:
Subject: Re: Fix handling of unlogged tables in FOR ALL TABLES publications