Postgres Pro
Downloads
Home   >   mailing lists

Re: SKIP LOCKED assert triggered - Mailing list pgsql-hackers

From Tom Lane
Subject Re: SKIP LOCKED assert triggered
Date
Msg-id 4030482.1641312930@sss.pgh.pa.us
Whole thread Raw
In response to Re: SKIP LOCKED assert triggered  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: SKIP LOCKED assert triggered
List pgsql-hackers
Tree view 
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Pushed, thanks Simon for reporting this problem.

Umm ...

       Assert(TM_WouldBlock || !(tuple->t_data->t_infomask & HEAP_XMAX_INVALID));

AFAICS, this assertion condition is constant-true,
because TM_WouldBlock is a nonzero constant.  Perhaps you meant

       Assert(result == TM_WouldBlock || !(tuple->t_data->t_infomask & HEAP_XMAX_INVALID));

?

I'd be inclined to format it more like the adjacent Assert, too.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: SKIP LOCKED assert triggered
Next
From: Bharath Rupireddy
Date:
Subject: Re: pg_walinspect - a new extension to get raw WAL data and WAL stats