Re: pgsql: libpq: Grease the protocol by default - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgsql: libpq: Grease the protocol by default
Date
Msg-id 4004006.1771959033@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: libpq: Grease the protocol by default  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: pgsql: libpq: Grease the protocol by default
List pgsql-hackers
Jacob Champion <jacob.champion@enterprisedb.com> writes:
> So pg_upgrade will use max_protocol_version=3.0 with all servers v10
> and below, in practice. There's nothing wrong with that behavior, but
> I think I should switch to a simple `< 1100` check in the code to
> avoid misleading people, unless anyone has a better way that won't
> significantly increase the cost of the backport.

Simple is good here.  I don't think we'd buy much by distinguishing
minor versions of already-EOL servers.  Also, I suspect that
pg_upgrade can't get the minor version except by starting the server
and asking it --- we don't record anything but major version on-disk.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Zsolt Parragi
Date:
Subject: Re: More speedups for tuple deformation
Next
From: Pavel Borisov
Date:
Subject: Re: New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering