Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) - Mailing list pgsql-hackers

Alexander Lakhin <exclusion@gmail.com> writes:
> And a warning:
> $ CC=gcc-12 CFLAGS="-Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-clobbered
> -Wno-missing-field-initializers" ./configure -q && make -s
> slru.c:63:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
>     63 | static int      inline
>        | ^~~~~~

> Maybe it's worth fixing before committing...

This should have been fixed before commit, because there are now a
dozen buildfarm animals complaining about it, as well as who-knows-
how-many developers' compilers.

 calliphoridae | 2023-11-30 02:48:59 |
/home/bf/bf-build/calliphoridae/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is
notat beginning of declaration [-Wold-style-declaration] 
 canebrake     | 2023-11-29 14:22:10 |
/home/bf/bf-build/canebrake/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is not
atbeginning of declaration [-Wold-style-declaration] 
 culicidae     | 2023-11-30 02:49:06 |
/home/bf/bf-build/culicidae/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is not
atbeginning of declaration [-Wold-style-declaration] 
 desmoxytes    | 2023-11-30 03:11:15 |
/home/bf/bf-build/desmoxytes/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is not
atbeginning of declaration [-Wold-style-declaration] 
 flaviventris  | 2023-11-30 02:53:19 |
/home/bf/bf-build/flaviventris/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is
notat beginning of declaration [-Wold-style-declaration] 
 francolin     | 2023-11-30 02:26:08 | ../pgsql/src/backend/access/transam/slru.c:63:1: warning: 'inline' is not at
beginningof declaration [-Wold-style-declaration] 
 grassquit     | 2023-11-30 02:58:36 |
/home/bf/bf-build/grassquit/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is not
atbeginning of declaration [-Wold-style-declaration] 
 komodoensis   | 2023-11-30 03:07:52 |
/home/bf/bf-build/komodoensis/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is not
atbeginning of declaration [-Wold-style-declaration] 
 phycodurus    | 2023-11-29 14:29:02 |
/home/bf/bf-build/phycodurus/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is not
atbeginning of declaration [-Wold-style-declaration] 
 piculet       | 2023-11-30 02:32:57 | ../pgsql/src/backend/access/transam/slru.c:63:1: warning: 'inline' is not at
beginningof declaration [-Wold-style-declaration] 
 pogona        | 2023-11-29 14:22:31 |
/home/bf/bf-build/pogona/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is not at
beginningof declaration [-Wold-style-declaration] 
 rorqual       | 2023-11-30 02:32:41 | ../pgsql/src/backend/access/transam/slru.c:63:1: warning: 'inline' is not at
beginningof declaration [-Wold-style-declaration] 
 serinus       | 2023-11-30 02:47:05 |
/home/bf/bf-build/serinus/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is not at
beginningof declaration [-Wold-style-declaration] 
 skink         | 2023-11-29 14:23:05 |
/home/bf/bf-build/skink-master/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is
notat beginning of declaration [-Wold-style-declaration] 
 taipan        | 2023-11-30 03:03:52 |
/home/bf/bf-build/taipan/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is not at
beginningof declaration [-Wold-style-declaration] 
 tamandua      | 2023-11-30 02:49:50 |
/home/bf/bf-build/tamandua/HEAD/pgsql.build/../pgsql/src/backend/access/transam/slru.c:63:1:warning: 'inline' is not at
beginningof declaration [-Wold-style-declaration] 

            regards, tom lane