Re: [HACKERS] merge psql ef/ev sf/sv handling functions - Mailing list pgsql-hackers

From Victor Drobny
Subject Re: [HACKERS] merge psql ef/ev sf/sv handling functions
Date
Msg-id 3fcca87aa4eacdc5981a5b219530dc1f@postgrespro.ru
Whole thread Raw
Responses Re: [HACKERS] merge psql ef/ev sf/sv handling functions
List pgsql-hackers
On 2017-03-31 21:04, Fabien COELHO wrote:
> Hello,
> 
> While reviewing Corey's \if patch, I complained that there was some
> amount of copy-paste in "psql/command.c".
> 
> Here is an attempt at merging some functions which removes 160 lines of 
> code.

Hello,

I was looking through your patch. It seems good, the of the functions 
was very similar.
I have a question for you. What was the reason to replace 
"printfPQExpBuffer" by "resetPQExpBuffer" and "appendPQExpBufferStr"?

Thank you for attention!

-- 
------
Victor Drobny
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] segfault in HEAD when too many nested functions call
Next
From: Alexey Chernyshov
Date:
Subject: [HACKERS] [PATCH] Add citext_pattern_ops to citext contrib module