Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without
Date
Msg-id 3f0b79eb1002010236g68009c3dmdaf8c985bcbbbc56@mail.gmail.com
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Mon, Feb 1, 2010 at 7:27 PM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> Fujii Masao wrote:
>> The cause of the problem seems to be the new heap created by
>> rebuild_relation() and copy_heap_data(), i.e., new VACUUM FULL.
>> Since it's not a temporary heap, its rd_istemp is off. OTOH
>> it needs to be synced after physical copy from old heap.
>
> Why does it need to be synced?
>
> ISTM the bug is that rd_istemp is off at that point.

Umm... ISTM that new heap needs to be synced before calling
swap_relation_files(), but, in the now, I'm not sure whether
it's really required or not. Sorry.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Rafael Martinez
Date:
Subject: PITR - Bug or feature?
Next
From: Fujii Masao
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without