On 2025/03/31 22:44, torikoshia wrote:
> Here are some comments on the documentation.
Thanks for the review!
> The following description in high-availability.sgml also seems to misuse the word 'consistent':
>
> When the <xref linkend="guc-hot-standby"/> parameter is set to true on a
> standby server, it will begin accepting connections once the recovery has
> brought the system to a consistent state.
>
> Since this is part of the "User's Overview" section, it may not be appropriate to include too much detail.
> How about rewording it to avoid using 'consistent', for example:
>
> When the <xref linkend="guc-hot-standby"/> parameter is set to true on a
> standby server, it will begin accepting connections once it is ready.
"once it is ready." feels too vague to me. How about using
"once recovery has brought the system to a consistent state and
be ready for hot standby." instead?
> + delaying accepting read-only connections. To enable hot standby,
> + a long-lived write transaction with more than 64 subtransactions
> + needs to be closed on the primary.
>
> Is it better to use 'transactions' in the plural form rather than as a nominal?
>
> - There may be more than one such transaction.
> - The <itemizedlist> below also uses the plural form.
> - The newly added message also uses the plural form:
> + errhint("To enable hot standby, close write transactions with more than %d subtransactions on the primary
server."
>
>
> What do you think?
I'm not sure whether the plural form is better here, but I've updated
the patch as suggested. Attached is the revised version.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
