Request a Demo
Home   >   mailing lists

Re: Fixing MSVC's inability to detect elog(ERROR) does not return - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Fixing MSVC's inability to detect elog(ERROR) does not return
Date
Msg-id 3df44c55-d943-4176-a5d1-ba59f3df2b52@eisentraut.org
Whole thread Raw
In response to Re: Fixing MSVC's inability to detect elog(ERROR) does not return  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Fixing MSVC's inability to detect elog(ERROR) does not return
List pgsql-hackers
Tree view 
On 27.09.25 12:43, David Rowley wrote:
> On Wed, 17 Sept 2025 at 15:52, David Rowley <dgrowleyml@gmail.com> wrote:
>> Updated patch attached.  Thanks for the review.
> 
> Now pushed and awaiting buildfarm feedback.

Cool, seems to work.  I also tried it on CI by removing a few "silence 
compiler warning" lines.

Quick follow-up: How about we rename pg_builtin_integer_constant_p to 
pg_integer_constant_p, since it's not actually built-in?  See attached 
patch.
Attachment

pgsql-hackers by date:

Previous
From: Alena Vinter
Date:
Subject: Re: Resetting recovery target parameters in pg_createsubscriber
Next
From: BharatDB
Date:
Subject: Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL