Re: Exit walsender before confirming remote flush in logical replication - Mailing list pgsql-hackers

From Andrey Silitskiy
Subject Re: Exit walsender before confirming remote flush in logical replication
Date
Msg-id 3d024a19-1256-4177-942a-d7173dacba74@postgrespro.ru
Whole thread Raw
In response to Re: Exit walsender before confirming remote flush in logical replication  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Jan 9, 2026 at 10:04 AM Fujii Masao
<masao(dot)fujii(at)gmail(dot)com> wrote:
> Why do we need to send a "done" message to the receiver here?
> Since delivery isn't guaranteed in immediate mode, it seems of limited
> value.

It seems to me that it is better to send a message in cases where it is
possible, so as not to raise errors on the subscriber during a clean shutdown.
And when this is not possible, exit the process without waiting.

> For the immediate mode, would it make sense to log that the walsender is
> terminating in immediate mode and that WAL replication may be incomplete,
> so users can more easily understand what happened?

Added to the latest patch.

Regards,
Andrey Silitskiy

pgsql-hackers by date:

Previous
From: Eric Ridge
Date:
Subject: Re: Fwd: pg18 bug? SELECT query doesn't work
Next
From: "Jonathan Gonzalez V."
Date:
Subject: [OAuth] Missing dependency on oauth_validator test