Re: PublicationActions - use bit flags. - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: PublicationActions - use bit flags.
Date
Msg-id 3b7f2bdd-77ed-00d7-437c-dd9c37e6a2fa@enterprisedb.com
Whole thread Raw
In response to PublicationActions - use bit flags.  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: PublicationActions - use bit flags.  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: PublicationActions - use bit flags.  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On 20.12.21 01:18, Peter Smith wrote:
> For some reason the current HEAD PublicationActions is a struct of
> boolean representing combinations of the 4 different "publication
> actions".
> 
> I felt it is more natural to implement boolean flag combinations using
> a bitmask instead of a struct of bools. IMO using the bitmask also
> simplifies assignment and checking of said flags.

I don't see why this is better.  It just makes the code longer and adds 
more punctuation and reduces type safety.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Column Filtering in Logical Replication
Next
From: Peter Eisentraut
Date:
Subject: Re: Getting rid of regression test input/ and output/ files