Re: WIP: Covering + unique indexes. - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: WIP: Covering + unique indexes.
Date
Msg-id 3b0791a7-dc4f-ea93-bc38-b14b1803ca3a@sigaev.ru
Whole thread Raw
In response to Re: WIP: Covering + unique indexes.  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: WIP: Covering + unique indexes.  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
Thank you, pushed.

> Actually, I see one tiny issue with extra '*' characters here:
> 
>> +            * The number of attributes won't be explicitly represented if the
>> +            * negative infinity tuple was generated during a page split that
>> +            * occurred with a version of Postgres before v11.  There must be a
>> +            * problem when there is an explicit representation that is
>> +            * non-zero, * or when there is no explicit representation and the
>> +            * tuple is * evidently not a pre-pg_upgrade tuple.
> 
> I also suggest fixing this indentation before commit:
> 
>> +   /*
>> +    *Cannot leak memory here, TupleDescCopy() doesn't allocate any
>> +    * inner structure, so, plain pfree() should clean all allocated memory
>> +    */

fixed

-- 
Teodor Sigaev                      E-mail: teodor@sigaev.ru
                                       WWW: http://www.sigaev.ru/


pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: Speedup of relation deletes during recovery
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Problem while updating a foreign table pointing to apartitioned table on foreign server